December 2018 - flashrom-gerrit

Change in ...flashrom[master]: chipset_enable.c: Mark Intel C224 as DEP
by Tristan Corrick (Code Review) Dec. 21, 2018

Dec. 21, 2018

Tristan Corrick has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30361 Change subject: chipset_enable.c: Mark Intel C224 as DEP ...................................................................... chipset_enable.c: Mark Intel C224 as DEP Tested on a Supermicro X10SLM+-F. The flash chip has been read, written, and erased many times without issue. Most boards with this chipset will have the ME region locked, hence the selection of DEP. Change-Id: I25126b94e691289a7b29dd81d5c864854a4e0245 Signed-off-by: Tristan Corrick <tristan(a)corrick.kiwi> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/30361/1 diff --git a/chipset_enable.c b/chipset_enable.c index c1639a6..90e5a60 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1841,7 +1841,7 @@ {0x8086, 0x8c51, NT, "Intel", "Lynx Point", enable_flash_pch8}, {0x8086, 0x8c52, NT, "Intel", "C222", enable_flash_pch8}, {0x8086, 0x8c53, NT, "Intel", "Lynx Point", enable_flash_pch8}, - {0x8086, 0x8c54, NT, "Intel", "C224", enable_flash_pch8}, + {0x8086, 0x8c54, DEP, "Intel", "C224", enable_flash_pch8}, {0x8086, 0x8c55, NT, "Intel", "Lynx Point", enable_flash_pch8}, {0x8086, 0x8c56, NT, "Intel", "C226", enable_flash_pch8}, {0x8086, 0x8c57, NT, "Intel", "Lynx Point", enable_flash_pch8}, -- To view, visit https://review.coreboot.org/c/flashrom/+/30361 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25126b94e691289a7b29dd81d5c864854a4e0245 Gerrit-Change-Number: 30361 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-MessageType: newchange

1 0

Change in ...flashrom[master]: Add CLI option to include a numeric range
by Nico Huber (Code Review) Dec. 19, 2018

Dec. 19, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28685 ) Change subject: Add CLI option to include a numeric range ...................................................................... Patch Set 1: How about a more implicit approach: Allow region names matching the pattern: <start>..<end> ? Whenever a region name isn't found but matches that pattern, flashrom could generate a region on the fly. Downside: Somebody could make funny things by adding a layout file entry with such a name. But we could warn about that when parsing a layout file, ofc. -- To view, visit https://review.coreboot.org/c/flashrom/+/28685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie2691051984bdeac128354c09bbe72aa05ef7401 Gerrit-Change-Number: 28685 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 19 Dec 2018 14:16:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: libflashrom.h: Remove line breaks in function signatures
by David Hendricks (Code Review) Dec. 15, 2018

Dec. 15, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 ) Change subject: libflashrom.h: Remove line breaks in function signatures ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) https://review.coreboot.org/#/c/30154/1/libflashrom.h File libflashrom.h: https://review.coreboot.org/#/c/30154/1/libflashrom.h@66 PS1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length); > I couldn't find anything in the wiki either. Not buried too deep for my […] Ah, here we go: https://mail.coreboot.org/pipermail/flashrom/2012-May/009228.html I think the tl;dr version is: - 80 columns soft limit - 112 columns hard limit - Tables are an exception and may be as long as needed for readability I went ahead and added this to the wiki: https://www.flashrom.org/Development_Guidelines#Coding_style I'll ping the mailing list as well in case others wish to add stuff or argue about those limits. -- To view, visit https://review.coreboot.org/c/flashrom/+/30154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9d9afb884d92f1edc3a806fa7e2d43808748d0f9 Gerrit-Change-Number: 30154 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 15 Dec 2018 01:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: libflashrom.h: Remove line breaks in function signatures
by Nico Huber (Code Review) Dec. 11, 2018

Dec. 11, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 ) Change subject: libflashrom.h: Remove line breaks in function signatures ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30154/1/libflashrom.h File libflashrom.h: https://review.coreboot.org/#/c/30154/1/libflashrom.h@66 PS1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length); > Doesn't this exceed the length limit now? (Heck, did we ever write down a length limit in a wiki som […] I couldn't find anything in the wiki either. Not buried too deep for my memory, though :) (scroll down to the second last hunk) https://mail.coreboot.org/pipermail/flashrom/2012-June/009388.html I don't know when the discussion took place. Must have been shortly before I started working on coreboot/flashrom. -- To view, visit https://review.coreboot.org/c/flashrom/+/30154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9d9afb884d92f1edc3a806fa7e2d43808748d0f9 Gerrit-Change-Number: 30154 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 21:41:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: libflashrom.h: Remove line breaks in function signatures
by David Hendricks (Code Review) Dec. 11, 2018

Dec. 11, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 ) Change subject: libflashrom.h: Remove line breaks in function signatures ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/30154/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30154/1//COMMIT_MSG@9 PS1, Line 9: I was once told we avoid such line breaks for better grep'ability. Not sure who said that, but AFAIK the argument usually applies to print statements. https://review.coreboot.org/#/c/30154/1/libflashrom.h File libflashrom.h: https://review.coreboot.org/#/c/30154/1/libflashrom.h@66 PS1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length); Doesn't this exceed the length limit now? (Heck, did we ever write down a length limit in a wiki somewhere, or does that only exist in a mailing discussion that's been buried for years now?) -- To view, visit https://review.coreboot.org/c/flashrom/+/30154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9d9afb884d92f1edc3a806fa7e2d43808748d0f9 Gerrit-Change-Number: 30154 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 20:48:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: libflashrom.h: Add missing includes
by David Hendricks (Code Review) Dec. 11, 2018

Dec. 11, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30153 ) Change subject: libflashrom.h: Add missing includes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifc84dfe2a06633321d0abd364bdea1216925a779 Gerrit-Change-Number: 30153 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 20:43:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: fmap: Fix length calculation in error message
by David Hendricks (Code Review) Dec. 11, 2018

Dec. 11, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30152 ) Change subject: fmap: Fix length calculation in error message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie0f448970de6a7829f304448e0835eaeb7d103a3 Gerrit-Change-Number: 30152 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Dec 2018 20:39:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: libflashrom.h: Add missing includes
by Nico Huber (Code Review) Dec. 11, 2018

Dec. 11, 2018

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30153 Change subject: libflashrom.h: Add missing includes ...................................................................... libflashrom.h: Add missing includes <stddef.h> for `size_t` and <sys/types.h> for `off_t`. Change-Id: Ifc84dfe2a06633321d0abd364bdea1216925a779 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M libflashrom.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/30153/1 diff --git a/libflashrom.h b/libflashrom.h index 4fbcd35..38c95d2 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -18,6 +18,8 @@ #ifndef __LIBFLASHROM_H__ #define __LIBFLASHROM_H__ 1 +#include <sys/types.h> +#include <stddef.h> #include <stdarg.h> int flashrom_init(int perform_selfcheck); -- To view, visit https://review.coreboot.org/c/flashrom/+/30153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifc84dfe2a06633321d0abd364bdea1216925a779 Gerrit-Change-Number: 30153 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in ...flashrom[master]: libflashrom.h: Remove line breaks in function signatures
by Nico Huber (Code Review) Dec. 11, 2018

Dec. 11, 2018

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30154 Change subject: libflashrom.h: Remove line breaks in function signatures ...................................................................... libflashrom.h: Remove line breaks in function signatures I was once told we avoid such line breaks for better grep'ability. Change-Id: I9d9afb884d92f1edc3a806fa7e2d43808748d0f9 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M libflashrom.h 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/30154/1 diff --git a/libflashrom.h b/libflashrom.h index 38c95d2..abff398 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -63,10 +63,8 @@ struct flashrom_layout; int flashrom_layout_read_from_ifd(struct flashrom_layout **, struct flashrom_flashctx *, const void *dump, size_t len); -int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, - struct flashrom_flashctx *, off_t offset, size_t length); -int flashrom_layout_read_fmap_from_buffer(struct flashrom_layout **layout, - struct flashrom_flashctx *, const uint8_t *buf, size_t len); +int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length); +int flashrom_layout_read_fmap_from_buffer(struct flashrom_layout **layout, struct flashrom_flashctx *, const uint8_t *buf, size_t len); int flashrom_layout_include_region(struct flashrom_layout *, const char *name); void flashrom_layout_release(struct flashrom_layout *); void flashrom_layout_set(struct flashrom_flashctx *, const struct flashrom_layout *); -- To view, visit https://review.coreboot.org/c/flashrom/+/30154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9d9afb884d92f1edc3a806fa7e2d43808748d0f9 Gerrit-Change-Number: 30154 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in ...flashrom[master]: fmap: Fix length calculation in error message
by Nico Huber (Code Review) Dec. 11, 2018

Dec. 11, 2018

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30152 Change subject: fmap: Fix length calculation in error message ...................................................................... fmap: Fix length calculation in error message Change-Id: Ie0f448970de6a7829f304448e0835eaeb7d103a3 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M fmap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/30152/1 diff --git a/fmap.c b/fmap.c index d44b7fa..84b3b54 100644 --- a/fmap.c +++ b/fmap.c @@ -243,7 +243,7 @@ if (flashctx->chip->read(flashctx, (uint8_t *)fmap + sig_len, offset + sig_len, sizeof(*fmap) - sig_len)) { msg_cerr("Cannot read %zu bytes at offset %06zx\n", - sizeof(*fmap) + sig_len, offset + sig_len); + sizeof(*fmap) - sig_len, offset + sig_len); continue; } -- To view, visit https://review.coreboot.org/c/flashrom/+/30152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie0f448970de6a7829f304448e0835eaeb7d103a3 Gerrit-Change-Number: 30152 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0