December 2018 - flashrom-gerrit

Change in ...flashrom[master]: chipset_enable.c: Mark Intel C224 as DEP
by Tristan Corrick (Code Review) 21 Dec '18

21 Dec '18

Tristan Corrick has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30361 Change subject: chipset_enable.c: Mark Intel C224 as DEP ...................................................................... chipset_enable.c: Mark Intel C224 as DEP Tested on a Supermicro X10SLM+-F. The flash chip has been read, written, and erased many times without issue. Most boards with this chipset will have the ME region locked, hence the selection of DEP. Change-Id: … [View More]

1 0

Change in ...flashrom[master]: Add CLI option to include a numeric range
by Nico Huber (Code Review) 19 Dec '18

19 Dec '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28685 ) Change subject: Add CLI option to include a numeric range ...................................................................... Patch Set 1: How about a more implicit approach: Allow region names matching the pattern: <start>..<end> ? Whenever a region name isn't found but matches that pattern, flashrom could generate a region on the fly. Downside: Somebody could make funny things … [View More]

1 0

Change in ...flashrom[master]: libflashrom.h: Remove line breaks in function signatures
by David Hendricks (Code Review) 15 Dec '18

15 Dec '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 ) Change subject: libflashrom.h: Remove line breaks in function signatures ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) https://review.coreboot.org/#/c/30154/1/libflashrom.h File libflashrom.h: https://review.coreboot.org/#/c/30154/1/libflashrom.h@66 PS1, Line 66: int … [View More]

1 0

Change in ...flashrom[master]: libflashrom.h: Remove line breaks in function signatures
by Nico Huber (Code Review) 11 Dec '18

11 Dec '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 ) Change subject: libflashrom.h: Remove line breaks in function signatures ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30154/1/libflashrom.h File libflashrom.h: https://review.coreboot.org/#/c/30154/1/libflashrom.h@66 PS1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct … [View More]

1 0

Change in ...flashrom[master]: libflashrom.h: Remove line breaks in function signatures
by David Hendricks (Code Review) 11 Dec '18

11 Dec '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 ) Change subject: libflashrom.h: Remove line breaks in function signatures ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/30154/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30154/1//COMMIT_MSG@9 PS1, Line 9: I was once told we avoid such line breaks for better grep'ability. Not sure who … [View More]

1 0

Change in ...flashrom[master]: libflashrom.h: Add missing includes
by David Hendricks (Code Review) 11 Dec '18

11 Dec '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30153 ) Change subject: libflashrom.h: Add missing includes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: … [View More]

1 0

Change in ...flashrom[master]: fmap: Fix length calculation in error message
by David Hendricks (Code Review) 11 Dec '18

11 Dec '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30152 ) Change subject: fmap: Fix length calculation in error message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30152 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: … [View More]

1 0

Change in ...flashrom[master]: libflashrom.h: Remove line breaks in function signatures
by Nico Huber (Code Review) 11 Dec '18

11 Dec '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30154 Change subject: libflashrom.h: Remove line breaks in function signatures ...................................................................... libflashrom.h: Remove line breaks in function signatures I was once told we avoid such line breaks for better grep'ability. Change-Id: I9d9afb884d92f1edc3a806fa7e2d43808748d0f9 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M libflashrom.… [View More]

1 0

Change in ...flashrom[master]: libflashrom.h: Add missing includes
by Nico Huber (Code Review) 11 Dec '18

11 Dec '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30153 Change subject: libflashrom.h: Add missing includes ...................................................................... libflashrom.h: Add missing includes <stddef.h> for `size_t` and <sys/types.h> for `off_t`. Change-Id: Ifc84dfe2a06633321d0abd364bdea1216925a779 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M libflashrom.h 1 file changed, 2 insertions(+), 0 … [View More]

1 0

Change in ...flashrom[master]: fmap: Fix length calculation in error message
by Nico Huber (Code Review) 11 Dec '18

11 Dec '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30152 Change subject: fmap: Fix length calculation in error message ...................................................................... fmap: Fix length calculation in error message Change-Id: Ie0f448970de6a7829f304448e0835eaeb7d103a3 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M fmap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/… [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2018