December 2018 - flashrom-gerrit

Change in ...flashrom[master]: Fix verification with sparse layouts

by Arthur Heymans (Code Review)

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30370 ) Change subject: Fix verification with sparse layouts ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Gerrit-Change-Number: 30370 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 14:28:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[master]: Fix verification with sparse layouts

by Arthur Heymans (Code Review)

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30370 ) Change subject: Fix verification with sparse layouts ...................................................................... Patch Set 3: > Patch Set 3: > > After some sleep, this looks good to me now. This is also much closer to what the code looked like before I wrote combine_image_by_layout(). > > For the future, I wonder, should we normalize the "UI" layout to something where we can make better assumptions? e.g. sort the regions, merge overlapping/directly following regions and fill gaps with non-included regions sounds good. Maybe it can even be extended to handle things like read and write protected regions? -- To view, visit https://review.coreboot.org/c/flashrom/+/30370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Gerrit-Change-Number: 30370 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 14:27:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[1.0.x]: Makefile: Disable `-Werror=deprecated-declarations` on release branch

by Arthur Heymans (Code Review)

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30373 ) Change subject: Makefile: Disable `-Werror=deprecated-declarations` on release branch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I6ed27b05b8b11f0ae1bcd331148cd61381edb8a0 Gerrit-Change-Number: 30373 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 14:09:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[1.0.x]: Makefile: Disable `-Werror=deprecated-declarations` on release branch

by Nico Huber (Code Review)

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30373 ) Change subject: Makefile: Disable `-Werror=deprecated-declarations` on release branch ...................................................................... Patch Set 1: > Patch Set 1: > > Why exacly is it needed? Jenkins can't build 1.0.x currently. I also wondered if this makes sense to put on a release branch... the targeted audience probably won't update libraries either if they can't update to a new major flashrom release. But still, it gets the job done and shouldn't hurt. -- To view, visit https://review.coreboot.org/c/flashrom/+/30373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I6ed27b05b8b11f0ae1bcd331148cd61381edb8a0 Gerrit-Change-Number: 30373 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 14:07:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[1.0.x]: Makefile: Disable `-Werror=deprecated-declarations` on release branch

by Arthur Heymans (Code Review)

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30373 ) Change subject: Makefile: Disable `-Werror=deprecated-declarations` on release branch ...................................................................... Patch Set 1: Why exacly is it needed? -- To view, visit https://review.coreboot.org/c/flashrom/+/30373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I6ed27b05b8b11f0ae1bcd331148cd61381edb8a0 Gerrit-Change-Number: 30373 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 13:59:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[1.0.x]: board_enable.c: Fix dmi_match string for ThinkPad X201

by Nico Huber (Code Review)

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30381 ) Change subject: board_enable.c: Fix dmi_match string for ThinkPad X201 ...................................................................... Patch Set 1: Code-Review+2 Already reviewed on master. -- To view, visit https://review.coreboot.org/c/flashrom/+/30381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I40dc7204499323148707b392d94ecd4b212f9ace Gerrit-Change-Number: 30381 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 13:43:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[1.0.x]: dediprog: Fix small, unaligned reads

by Nico Huber (Code Review)

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30380 ) Change subject: dediprog: Fix small, unaligned reads ...................................................................... Patch Set 2: Code-Review+2 Already reviewed on master. -- To view, visit https://review.coreboot.org/c/flashrom/+/30380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Gerrit-Change-Number: 30380 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Sat, 22 Dec 2018 13:41:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[1.0.x]: dediprog: Fix small, unaligned reads

by Nico Huber (Code Review)

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30380 ) Change subject: dediprog: Fix small, unaligned reads ...................................................................... Patch Set 2: Patrick, there seems to be a problem with the commit-message-update rule. This shouldn't have Verified+1, AFAICS (earlier failure of flashrom_gerrit is ignored). -- To view, visit https://review.coreboot.org/c/flashrom/+/30380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Gerrit-Change-Number: 30380 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Sat, 22 Dec 2018 13:40:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[1.0.x]: linux_spi: Hardcode default spispeed of 2MHz

by Nico Huber (Code Review)

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30371 ) Change subject: linux_spi: Hardcode default spispeed of 2MHz ...................................................................... Patch Set 2: Code-Review+2 Reviewed and tested on master. -- To view, visit https://review.coreboot.org/c/flashrom/+/30371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I9361b7c1a1ab8900a619b06e1dae14cd87eb56c2 Gerrit-Change-Number: 30371 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 13:36:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

Change in ...flashrom[1.0.x]: board_enable.c: Fix dmi_match string for ThinkPad X201

by Nico Huber (Code Review)

Hello Patrick Rudolph, Arthur Heymans, Paul Menzel, build bot (Jenkins), I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/30381 to review the following change. Change subject: board_enable.c: Fix dmi_match string for ThinkPad X201 ...................................................................... board_enable.c: Fix dmi_match string for ThinkPad X201 TESTED, flashrom now properly works on Thinkpad X201 running vendor firmware and coreboot. Change-Id: I40dc7204499323148707b392d94ecd4b212f9ace Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/27504 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- M board_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/30381/1 diff --git a/board_enable.c b/board_enable.c index b6e17ef..3b6755e 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2433,7 +2433,7 @@ {0x8086, 0x27a0, 0x17aa, 0x2015, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T60", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27a0, 0x17aa, 0x2017, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T60(s)", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad X200", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X200", 0, OK, p2_whitelist_laptop}, - {0x8086, 0x3B07, 0x17AA, 0x2166, 0x8086, 0x3B30, 0x17AA, 0x2167, "^Lenovo X201", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X201", 0, OK, p2_whitelist_laptop}, + {0x8086, 0x3B07, 0x17AA, 0x2166, 0x8086, 0x3B30, 0x17AA, 0x2167, "^ThinkPad X201", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X201", 0, OK, p2_whitelist_laptop}, {0x8086, 0x1E22, 0x17AA, 0x21FA, 0x8086, 0x1E55, 0x17AA, 0x21FA, "^ThinkPad X230", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X230", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27A0, 0x17AA, 0x2017, 0x8086, 0x27B9, 0x17AA, 0x2009, "^ThinkPad X60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X60(s)", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2411, 0x8086, 0x2411, 0x8086, 0x7125, 0x0e11, 0xb165, NULL, NULL, NULL, P3, "Mitac", "6513WU", 0, OK, board_mitac_6513wu}, -- To view, visit https://review.coreboot.org/c/flashrom/+/30381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I40dc7204499323148707b392d94ecd4b212f9ace Gerrit-Change-Number: 30381 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newchange

10 months, 3 weeks

1
0
0 0

2019

2018

2017

flashrom-gerrit December 2018