December 2018 - flashrom-gerrit

Change in ...flashrom[1.0.x]: board_enable.c: Fix dmi_match string for ThinkPad X201
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30381 ) Change subject: board_enable.c: Fix dmi_match string for ThinkPad X201 ...................................................................... board_enable.c: Fix dmi_match string for ThinkPad X201 TESTED, flashrom now properly works on Thinkpad X201 running vendor firmware and coreboot. Change-Id: I40dc7204499323148707b392d94ecd4b212f9ace Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/27504 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: https://review.coreboot.org/c/30381 Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M board_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/board_enable.c b/board_enable.c index b6e17ef..3b6755e 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2433,7 +2433,7 @@ {0x8086, 0x27a0, 0x17aa, 0x2015, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T60", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27a0, 0x17aa, 0x2017, 0x8086, 0x27b9, 0x17aa, 0x2009, "^ThinkPad T60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad T60(s)", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2917, 0x17AA, 0x20F5, 0x8086, 0x2930, 0x17AA, 0x20F9, "^ThinkPad X200", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X200", 0, OK, p2_whitelist_laptop}, - {0x8086, 0x3B07, 0x17AA, 0x2166, 0x8086, 0x3B30, 0x17AA, 0x2167, "^Lenovo X201", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X201", 0, OK, p2_whitelist_laptop}, + {0x8086, 0x3B07, 0x17AA, 0x2166, 0x8086, 0x3B30, 0x17AA, 0x2167, "^ThinkPad X201", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X201", 0, OK, p2_whitelist_laptop}, {0x8086, 0x1E22, 0x17AA, 0x21FA, 0x8086, 0x1E55, 0x17AA, 0x21FA, "^ThinkPad X230", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X230", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27A0, 0x17AA, 0x2017, 0x8086, 0x27B9, 0x17AA, 0x2009, "^ThinkPad X60", NULL, NULL, P2, "IBM/Lenovo", "ThinkPad X60(s)", 0, OK, p2_whitelist_laptop}, {0x8086, 0x2411, 0x8086, 0x2411, 0x8086, 0x7125, 0x0e11, 0xb165, NULL, NULL, NULL, P3, "Mitac", "6513WU", 0, OK, board_mitac_6513wu}, -- To view, visit https://review.coreboot.org/c/flashrom/+/30381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I40dc7204499323148707b392d94ecd4b212f9ace Gerrit-Change-Number: 30381 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...flashrom[1.0.x]: dediprog: Fix small, unaligned reads
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30380 ) Change subject: dediprog: Fix small, unaligned reads ...................................................................... dediprog: Fix small, unaligned reads This never was a use case until now but the `--fmap` code makes it obvious: Unaligned reads that were smaller than the `chunksize` here, were extended without considering the length of the buffer read into. With that fixed we run into the next problem: dediprog_spi_bulk_read() shouldn't report an error when an empty read is unaligned. Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/30051 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/30380 Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M dediprog.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/dediprog.c b/dediprog.c index 2f5b441..70660d4 100644 --- a/dediprog.c +++ b/dediprog.c @@ -425,15 +425,15 @@ struct libusb_transfer *transfers[DEDIPROG_ASYNC_TRANSFERS] = { NULL, }; struct libusb_transfer *transfer; + if (len == 0) + return 0; + if ((start % chunksize) || (len % chunksize)) { msg_perr("%s: Unaligned start=%i, len=%i! Please report a bug at flashrom(a)flashrom.org\n", __func__, start, len); return 1; } - if (len == 0) - return 0; - /* Command packet size of protocols: new 10 B, old 5 B. */ uint8_t data_packet[is_new_prot() ? 10 : 5]; unsigned int value, idx; @@ -503,7 +503,7 @@ int ret; /* chunksize must be 512, other sizes will NOT work at all. */ const unsigned int chunksize = 0x200; - unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; + unsigned int residue = start % chunksize ? min(len, chunksize - start % chunksize) : 0; unsigned int bulklen; dediprog_set_leds(LED_BUSY); -- To view, visit https://review.coreboot.org/c/flashrom/+/30380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Gerrit-Change-Number: 30380 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: merged

1 0

Change in ...flashrom[1.0.x]: linux_spi: Hardcode default spispeed of 2MHz
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30371 ) Change subject: linux_spi: Hardcode default spispeed of 2MHz ...................................................................... linux_spi: Hardcode default spispeed of 2MHz Leaving the `linux_spi` driver's unknown default is almost never what we want and resulted in many support requests since Raspbian switched to a default that is too high for most applications. Change-Id: I9361b7c1a1ab8900a619b06e1dae14cd87eb56c2 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/30371 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M linux_spi.c 1 file changed, 13 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/linux_spi.c b/linux_spi.c index d276402..a380477 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -22,6 +22,8 @@ #include <stdio.h> #include <string.h> #include <stdlib.h> +#include <stdint.h> +#include <inttypes.h> #include <fcntl.h> #include <errno.h> #include <ctype.h> @@ -67,7 +69,7 @@ int linux_spi_init(void) { char *p, *endp, *dev; - uint32_t speed_hz = 0; + uint32_t speed_hz = 2 * 1000 * 1000; /* FIXME: make the following configurable by CLI options. */ /* SPI mode 0 (beware this also includes: MSB first, CS active low and others */ const uint8_t mode = SPI_MODE_0; @@ -76,11 +78,15 @@ p = extract_programmer_param("spispeed"); if (p && strlen(p)) { speed_hz = (uint32_t)strtoul(p, &endp, 10) * 1000; - if (p == endp) { + if (p == endp || speed_hz == 0) { msg_perr("%s: invalid clock: %s kHz\n", __func__, p); free(p); return 1; } + } else { + msg_pinfo("Using default %"PRIu32 + "kHz clock. Use 'spispeed' parameter to override.\n", + speed_hz / 1000); } free(p); @@ -105,15 +111,12 @@ return 1; /* We rely on the shutdown function for cleanup from here on. */ - if (speed_hz > 0) { - if (ioctl(fd, SPI_IOC_WR_MAX_SPEED_HZ, &speed_hz) == -1) { - msg_perr("%s: failed to set speed to %d Hz: %s\n", - __func__, speed_hz, strerror(errno)); - return 1; - } - - msg_pdbg("Using %d kHz clock\n", speed_hz/1000); + if (ioctl(fd, SPI_IOC_WR_MAX_SPEED_HZ, &speed_hz) == -1) { + msg_perr("%s: failed to set speed to %"PRIu32"Hz: %s\n", + __func__, speed_hz, strerror(errno)); + return 1; } + msg_pdbg("Using %"PRIu32"kHz clock\n", speed_hz / 1000); if (ioctl(fd, SPI_IOC_WR_MODE, &mode) == -1) { msg_perr("%s: failed to set SPI mode to 0x%02x: %s\n", -- To view, visit https://review.coreboot.org/c/flashrom/+/30371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I9361b7c1a1ab8900a619b06e1dae14cd87eb56c2 Gerrit-Change-Number: 30371 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...flashrom[1.0.x]: Makefile: Disable `-Werror=deprecated-declarations` on release branch
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30373 ) Change subject: Makefile: Disable `-Werror=deprecated-declarations` on release branch ...................................................................... Makefile: Disable `-Werror=deprecated-declarations` on release branch Change-Id: I6ed27b05b8b11f0ae1bcd331148cd61381edb8a0 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/30373 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved diff --git a/Makefile b/Makefile index 9cf52b2..7fcccd8 100644 --- a/Makefile +++ b/Makefile @@ -63,7 +63,7 @@ WARNERROR ?= yes ifeq ($(WARNERROR), yes) -CFLAGS += -Werror +CFLAGS += -Werror -Wno-error=deprecated-declarations endif ifdef LIBS_BASE -- To view, visit https://review.coreboot.org/c/flashrom/+/30373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I6ed27b05b8b11f0ae1bcd331148cd61381edb8a0 Gerrit-Change-Number: 30373 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...flashrom[master]: dediprog: Enable 4BA support for SF600, protocol V2
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28804 ) Change subject: dediprog: Enable 4BA support for SF600, protocol V2 ...................................................................... Patch Set 2: >> Did you test the native instructions only? e.g. you could remove >> the native flags / erase functions (and in another step the enter >> 4BA flags) for your chip to test different paths. > > I think so... I tried with only FEATURE_4BA_NATIVE enabled and I also tried with only FEATURE_4BA enabled, the former should have used native instructions only, right? > Alas, FEATURE_4BA includes _NATIVE and the latter is automatically selected if available. So it's likely you tested native instructions twice. -- To view, visit https://review.coreboot.org/c/flashrom/+/28804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I665d0806aec469a3509620a760815861fbe22841 Gerrit-Change-Number: 28804 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 22 Dec 2018 17:03:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: dediprog: Disable 4BA completely
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30386 ) Change subject: dediprog: Disable 4BA completely ...................................................................... Patch Set 1: I'd like to have this in for the 1.1 release. The follow-up too if somebody can confirm it's working. -- To view, visit https://review.coreboot.org/c/flashrom/+/30386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08efcbb09ab3499ef6902a698e9ce3d6232237c4 Gerrit-Change-Number: 30386 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 16:59:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: dediprog: Enable 4BA support for SF600, protocol V2
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28804 ) Change subject: dediprog: Enable 4BA support for SF600, protocol V2 ...................................................................... Patch Set 2: (1 comment) I've reduced this to the single path that is expected to work and tried to minimize changes. If somebody figures out more working combinations, I'd be happy to merged them. But I'll probably not work on this myself (unless my employment comes into play). Even the Dediprog specification I got my hands on is worth less than a USB trace. It doesn't tell what is going on on the SPI side. It's probably easier to write proper firmware for these devices than to use what Dediprog ships. https://review.coreboot.org/#/c/28804/1/dediprog.c File dediprog.c: https://review.coreboot.org/#/c/28804/1/dediprog.c@399 PS1, Line 399: data_packet[13] = 0x00; > Perhaps. But at least I have one known good configuration. Let's start with that. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/28804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I665d0806aec469a3509620a760815861fbe22841 Gerrit-Change-Number: 28804 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 22 Dec 2018 16:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: dediprog: Disable 4BA completely
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30386 Change subject: dediprog: Disable 4BA completely ...................................................................... dediprog: Disable 4BA completely This is an interim solution. We'll have to enable 4BA step-by-step for each dediprog protocol version. Change-Id: I08efcbb09ab3499ef6902a698e9ce3d6232237c4 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M dediprog.c M flashrom.c M programmer.h 3 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/30386/1 diff --git a/dediprog.c b/dediprog.c index 72818ea..3cac360 100644 --- a/dediprog.c +++ b/dediprog.c @@ -933,6 +933,7 @@ static const struct spi_master spi_master_dediprog = { .type = SPI_CONTROLLER_DEDIPROG, + .features = SPI_MASTER_NO_4BA_MODES, .max_data_read = 16, /* 18 seems to work fine as well, but 19 times out sometimes with FW 5.15. */ .max_data_write = 16, .command = dediprog_spi_send_command, diff --git a/flashrom.c b/flashrom.c index 59a7531..b229228 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2258,6 +2258,16 @@ flash->address_high_byte = -1; flash->in_4ba_mode = false; + /* Be careful about 4BA chips and broken masters */ + if (flash->chip->total_size > 16 * 1024 && spi_master_no_4ba_modes(flash)) { + /* If we can't use native instructions, bail out */ + if ((flash->chip->feature_bits & FEATURE_4BA_NATIVE) != FEATURE_4BA_NATIVE + || !spi_master_4ba(flash)) { + msg_cerr("Programmer doesn't support this chip. Aborting.\n"); + return 1; + } + } + /* Enable/disable 4-byte addressing mode if flash chip supports it */ if (flash->chip->feature_bits & (FEATURE_4BA_ENTER | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_ENTER_EAR7)) { int ret; diff --git a/programmer.h b/programmer.h index 311992a..8c2ae28 100644 --- a/programmer.h +++ b/programmer.h @@ -648,6 +648,8 @@ #define MAX_DATA_WRITE_UNLIMITED 256 #define SPI_MASTER_4BA (1U << 0) /**< Can handle 4-byte addresses */ +#define SPI_MASTER_NO_4BA_MODES (1U << 1) /**< Compatibility modes (i.e. extended address + register, 4BA mode switch) don't work */ struct spi_master { enum spi_controller type; @@ -840,6 +842,11 @@ return flash->mst->buses_supported & BUS_SPI && flash->mst->spi.features & SPI_MASTER_4BA; } +static inline bool spi_master_no_4ba_modes(const struct flashctx *const flash) +{ + return flash->mst->buses_supported & BUS_SPI && + flash->mst->spi.features & SPI_MASTER_NO_4BA_MODES; +} /* usbdev.c */ struct libusb_device_handle; -- To view, visit https://review.coreboot.org/c/flashrom/+/30386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08efcbb09ab3499ef6902a698e9ce3d6232237c4 Gerrit-Change-Number: 30386 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in ...flashrom[master]: dediprog: Enable 4BA support for SF600, protocol V2
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Hello David Hendricks, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/28804 to look at the new patch set (#2). Change subject: dediprog: Enable 4BA support for SF600, protocol V2 ...................................................................... dediprog: Enable 4BA support for SF600, protocol V2 The only combination we could successfully test so far is the SF600 with protocol version V2 (firmware 7.2.21) and native 4BA commands. Let's enable that at least. Change-Id: I665d0806aec469a3509620a760815861fbe22841 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M dediprog.c M spi.h 2 files changed, 28 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/28804/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/28804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I665d0806aec469a3509620a760815861fbe22841 Gerrit-Change-Number: 28804 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in ...flashrom[master]: Fix verification with sparse layouts
by Nico Huber (Code Review) Dec. 22, 2018

Dec. 22, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30370 ) Change subject: Fix verification with sparse layouts ...................................................................... Patch Set 3: >> For the future, I wonder, should we normalize the "UI" layout to something where we can make better assumptions? e.g. sort the regions, merge overlapping/directly following regions and fill gaps with non-included regions > > sounds good. Maybe it can even be extended to handle things like read and write protected regions? Yes, that seems to be the logical next step. Gather all the information first and when we prepare the layout for the actual flash access, check things like that. i.e. regions may overlap generally, but not if one says it's protected and the other says we are going to access it. -- To view, visit https://review.coreboot.org/c/flashrom/+/30370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Gerrit-Change-Number: 30370 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 14:55:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0