flashrom-gerrit December 2018

flashrom-gerrit@flashrom.org

1 participants
74 discussions

Change in ...flashrom[master]: [HACK]flashchips: Use spi_chip_write_256 on SST25VF016B
by Arthur Heymans (Code Review) 06 Dec '18

06 Dec '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30088 Change subject: [HACK]flashchips: Use spi_chip_write_256 on SST25VF016B ...................................................................... [HACK]flashchips: Use spi_chip_write_256 on SST25VF016B Change-Id: I8000f538a55c10dd55aedd4265c036590f3b96a8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/30088/1 diff --git a/flashchips.c b/flashchips.c index 17cb1b4..dc713ab 100644 --- a/flashchips.c +++ b/flashchips.c @@ -12912,7 +12912,7 @@ }, .printlock = spi_prettyprint_status_register_sst25vf016, .unlock = spi_disable_blockprotect, - .write = spi_aai_write, + .write = spi_chip_write_256, .read = spi_chip_read, .voltage = {2700, 3600}, }, -- To view, visit https://review.coreboot.org/c/flashrom/+/30088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8000f538a55c10dd55aedd4265c036590f3b96a8 Gerrit-Change-Number: 30088 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in ...flashrom[master]: dediprog: Fix small, unaligned reads
by Nico Huber (Code Review) 06 Dec '18

06 Dec '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30051 ) Change subject: dediprog: Fix small, unaligned reads ...................................................................... dediprog: Fix small, unaligned reads This never was a use case until now but the `--fmap` code makes it obvious: Unaligned reads that were smaller than the `chunksize` here, were extended without considering the length of the buffer read into. With that fixed we run into the next problem: dediprog_spi_bulk_read() shouldn't report an error when an empty read is unaligned. Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/30051 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M dediprog.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/dediprog.c b/dediprog.c index 58f1d43..72818ea 100644 --- a/dediprog.c +++ b/dediprog.c @@ -412,15 +412,15 @@ struct libusb_transfer *transfers[DEDIPROG_ASYNC_TRANSFERS] = { NULL, }; struct libusb_transfer *transfer; + if (len == 0) + return 0; + if ((start % chunksize) || (len % chunksize)) { msg_perr("%s: Unaligned start=%i, len=%i! Please report a bug at flashrom(a)flashrom.org\n", __func__, start, len); return 1; } - if (len == 0) - return 0; - int command_packet_size; switch (protocol()) { case PROTOCOL_V1: @@ -504,7 +504,7 @@ int ret; /* chunksize must be 512, other sizes will NOT work at all. */ const unsigned int chunksize = 0x200; - unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; + unsigned int residue = start % chunksize ? min(len, chunksize - start % chunksize) : 0; unsigned int bulklen; dediprog_set_leds(LED_BUSY); -- To view, visit https://review.coreboot.org/c/flashrom/+/30051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Gerrit-Change-Number: 30051 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...flashrom[master]: dediprog: Fix small, unaligned reads
by David Hendricks (Code Review) 05 Dec '18

05 Dec '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30051 ) Change subject: dediprog: Fix small, unaligned reads ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Gerrit-Change-Number: 30051 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Dec 2018 23:48:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: dediprog: Fix small, unaligned reads
by Nico Huber (Code Review) 05 Dec '18

05 Dec '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30051 Change subject: dediprog: Fix small, unaligned reads ...................................................................... dediprog: Fix small, unaligned reads This never was a use case until now but the `--fmap` code makes it obvious: Unaligned reads that were smaller than the `chunksize` here, were extended without considering the length of the buffer read into. With that fixed we run into the next problem: dediprog_spi_bulk_read() shouldn't report an error when an empty read is unaligned. Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M dediprog.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/30051/1 diff --git a/dediprog.c b/dediprog.c index 58f1d43..72818ea 100644 --- a/dediprog.c +++ b/dediprog.c @@ -412,15 +412,15 @@ struct libusb_transfer *transfers[DEDIPROG_ASYNC_TRANSFERS] = { NULL, }; struct libusb_transfer *transfer; + if (len == 0) + return 0; + if ((start % chunksize) || (len % chunksize)) { msg_perr("%s: Unaligned start=%i, len=%i! Please report a bug at flashrom(a)flashrom.org\n", __func__, start, len); return 1; } - if (len == 0) - return 0; - int command_packet_size; switch (protocol()) { case PROTOCOL_V1: @@ -504,7 +504,7 @@ int ret; /* chunksize must be 512, other sizes will NOT work at all. */ const unsigned int chunksize = 0x200; - unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; + unsigned int residue = start % chunksize ? min(len, chunksize - start % chunksize) : 0; unsigned int bulklen; dediprog_set_leds(LED_BUSY); -- To view, visit https://review.coreboot.org/c/flashrom/+/30051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Gerrit-Change-Number: 30051 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2018