December 2018 - flashrom-gerrit

Change in ...flashrom[1.0.x]: dediprog: Fix small, unaligned reads
by Nico Huber (Code Review) 22 Dec '18

22 Dec '18

Hello David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30380 to look at the new patch set (#2). Change subject: dediprog: Fix small, unaligned reads ...................................................................... dediprog: Fix small, unaligned reads This never was a use case until now but the `--fmap` code makes it obvious: Unaligned reads that were smaller than the `chunksize` here, were extended without considering the length of the buffer read into. With that fixed we run into the next problem: dediprog_spi_bulk_read() shouldn't report an error when an empty read is unaligned. Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/30051 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M dediprog.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/30380/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Gerrit-Change-Number: 30380 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...flashrom[1.0.x]: dediprog: Fix small, unaligned reads
by Nico Huber (Code Review) 22 Dec '18

22 Dec '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/30380 Change subject: dediprog: Fix small, unaligned reads ...................................................................... dediprog: Fix small, unaligned reads This never was a use case until now but the `--fmap` code makes it obvious: Unaligned reads that were smaller than the `chunksize` here, were extended without considering the length of the buffer read into. With that fixed we run into the next problem: dediprog_spi_bulk_read() shouldn't report an error when an empty read is unaligned. Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M dediprog.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/30380/1 diff --git a/dediprog.c b/dediprog.c index 2f5b441..70660d4 100644 --- a/dediprog.c +++ b/dediprog.c @@ -425,15 +425,15 @@ struct libusb_transfer *transfers[DEDIPROG_ASYNC_TRANSFERS] = { NULL, }; struct libusb_transfer *transfer; + if (len == 0) + return 0; + if ((start % chunksize) || (len % chunksize)) { msg_perr("%s: Unaligned start=%i, len=%i! Please report a bug at flashrom(a)flashrom.org\n", __func__, start, len); return 1; } - if (len == 0) - return 0; - /* Command packet size of protocols: new 10 B, old 5 B. */ uint8_t data_packet[is_new_prot() ? 10 : 5]; unsigned int value, idx; @@ -503,7 +503,7 @@ int ret; /* chunksize must be 512, other sizes will NOT work at all. */ const unsigned int chunksize = 0x200; - unsigned int residue = start % chunksize ? chunksize - start % chunksize : 0; + unsigned int residue = start % chunksize ? min(len, chunksize - start % chunksize) : 0; unsigned int bulklen; dediprog_set_leds(LED_BUSY); -- To view, visit https://review.coreboot.org/c/flashrom/+/30380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Ie12b62499ebfdb467d5126c00d327c76077ddead Gerrit-Change-Number: 30380 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in ...flashrom[master]: chipset_enable.c: Mark Intel C224 as DEP
by Nico Huber (Code Review) 22 Dec '18

22 Dec '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/30361 ) Change subject: chipset_enable.c: Mark Intel C224 as DEP ...................................................................... chipset_enable.c: Mark Intel C224 as DEP Tested on a Supermicro X10SLM+-F. The flash chip has been read, written, and erased many times without issue. Most boards with this chipset will have the ME region locked, hence the selection of DEP. Change-Id: I25126b94e691289a7b29dd81d5c864854a4e0245 Signed-off-by: Tristan Corrick <tristan(a)corrick.kiwi> Reviewed-on: https://review.coreboot.org/c/30361 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index cbb88fd..4d624a3 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1841,7 +1841,7 @@ {0x8086, 0x8c51, NT, "Intel", "Lynx Point", enable_flash_pch8}, {0x8086, 0x8c52, NT, "Intel", "C222", enable_flash_pch8}, {0x8086, 0x8c53, NT, "Intel", "Lynx Point", enable_flash_pch8}, - {0x8086, 0x8c54, NT, "Intel", "C224", enable_flash_pch8}, + {0x8086, 0x8c54, DEP, "Intel", "C224", enable_flash_pch8}, {0x8086, 0x8c55, NT, "Intel", "Lynx Point", enable_flash_pch8}, {0x8086, 0x8c56, NT, "Intel", "C226", enable_flash_pch8}, {0x8086, 0x8c57, NT, "Intel", "Lynx Point", enable_flash_pch8}, -- To view, visit https://review.coreboot.org/c/flashrom/+/30361 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25126b94e691289a7b29dd81d5c864854a4e0245 Gerrit-Change-Number: 30361 Gerrit-PatchSet: 3 Gerrit-Owner: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...flashrom[master]: Fix verification with sparse layouts
by Nico Huber (Code Review) 22 Dec '18

22 Dec '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30370 ) Change subject: Fix verification with sparse layouts ...................................................................... Patch Set 3: After some sleep, this looks good to me now. This is also much closer to what the code looked like before I wrote combine_image_by_layout(). For the future, I wonder, should we normalize the "UI" layout to something where we can make better assumptions? e.g. sort the regions, merge overlapping/directly following regions and fill gaps with non-included regions -- To view, visit https://review.coreboot.org/c/flashrom/+/30370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Gerrit-Change-Number: 30370 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 12:53:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: linux_spi: Hardcode default spispeed of 2MHz
by Arthur Heymans (Code Review) 22 Dec '18

22 Dec '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30368 ) Change subject: linux_spi: Hardcode default spispeed of 2MHz ...................................................................... Patch Set 1: Code-Review+2 Tested on an Allwinner H3 board on which the default frequency is not good to operate a SPI flash. -- To view, visit https://review.coreboot.org/c/flashrom/+/30368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9361b7c1a1ab8900a619b06e1dae14cd87eb56c2 Gerrit-Change-Number: 30368 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 09:54:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: layout: Show a warning if no region is included
by Philippe Mathieu-Daudé (Code Review) 22 Dec '18

22 Dec '18

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30369 ) Change subject: layout: Show a warning if no region is included ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/30369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I53b749ce42ecc6c267b6cbe71413d536ec3965c5 Gerrit-Change-Number: 30369 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 07:44:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: Fix verification with sparse layouts
by Nico Huber (Code Review) 22 Dec '18

22 Dec '18

Hello Angel Pons, Arthur Heymans, David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30370 to look at the new patch set (#3). Change subject: Fix verification with sparse layouts ...................................................................... Fix verification with sparse layouts The full verification step was not accounting for sparse layouts. Instead of the old contents, combine_image_by_layout() implicitly assumed the new contents for unspecified regions. Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashrom.c M layout.c M layout.h 3 files changed, 34 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/30370/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/30370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Gerrit-Change-Number: 30370 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...flashrom[master]: Fix verification with sparse layouts
by Nico Huber (Code Review) 22 Dec '18

22 Dec '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30370 ) Change subject: Fix verification with sparse layouts ...................................................................... Patch Set 2: -Code-Review -- To view, visit https://review.coreboot.org/c/flashrom/+/30370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Gerrit-Change-Number: 30370 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 01:47:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: Fix verification with sparse layouts
by Nico Huber (Code Review) 22 Dec '18

22 Dec '18

Hello Angel Pons, Arthur Heymans, David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/30370 to look at the new patch set (#2). Change subject: Fix verification with sparse layouts ...................................................................... Fix verification with sparse layouts The full verification step was not accounting for sparse layouts. Instead of the old contents, combine_image_by_layout() implicitly assumed the new contents for unspecified regions. Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashrom.c M layout.c M layout.h 3 files changed, 32 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/30370/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Gerrit-Change-Number: 30370 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...flashrom[master]: Fix verification with sparse layouts
by Nico Huber (Code Review) 22 Dec '18

22 Dec '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30370 ) Change subject: Fix verification with sparse layouts ...................................................................... Patch Set 1: Code-Review-2 Assumes layout entries are ordered... -- To view, visit https://review.coreboot.org/c/flashrom/+/30370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a Gerrit-Change-Number: 30370 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Dec 2018 01:07:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2018