Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36340 )
Change subject: ec/google/chromeec: Clean up ec.[ch]
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36340/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36340/3//COMMIT_MSG@11
PS3, Line 11: Use static struct initialization to ensure all fields are initialized.
I think something unintended happened here, you didn't just do the clean-up you also squashed CB:362 […]
Ack, I thought I fixed this...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1e29e88975c85eea215adedc5f5e483243e0d6
Gerrit-Change-Number: 36340
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Oct 2019 23:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment