Attention is currently required from: Derek Huang, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu.
Robert Chen has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Update ext_vr for board version > b
......................................................................
Patch Set 15:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84953/comment/5714585b_a9f1b804?usp... :
PS14, Line 13:
Too many blank lines. Please leave just one blank line between here and BUG line.
Done
File src/mainboard/google/dedede/variants/drawcia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/84953/comment/476a36e1_41476ba8?usp... :
PS14, Line 39: if (board_version != 0xa &&
: board_version != 0xb &&
: board_version != 0xf)
Can be wrapped into one line? Sorry I missed this earlier.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 15
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 05 Nov 2024 06:20:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com