1 Nov
2022
1 Nov
'22
5:44 p.m.
Attention is currently required from: Hung-Te Lin, Jakub Czapiga, Julius Werner, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68768 )
Change subject: lib/coreboot_table: Simplify API to set up lb_serial ......................................................................
Patch Set 8:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/68768/comment/ac88a216_344cebb6 PS8, Line 111: else
one last concern is should we do a check/assert here, and only add LB_TAG_CONSOLE_SERIAL8250MEM cons […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d
Gerrit-Change-Number: 68768
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Arthur Heymans arthur.heymans@9elements.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 17:44:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment