Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42062 )
Change subject: src/*: Update makefiles to exclude x86 code from psp-verstage
......................................................................
Patch Set 11: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/42062/4/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/4/Makefile.inc@616
PS4, Line 616:
: ifeq ($(CONFIG_ARCH_VERSTAGE_X86_32)$(CONFIG_ARCH_VERSTAGE_X86_64),y)
: verstage-y += $(verstage-x86_32_64-y)
: endif
Left over from an earlier version. Will remove.
Done
https://review.coreboot.org/c/coreboot/+/42062/6/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/6/Makefile.inc@104
PS6, Line 104: x86_verstage
Sure, I can update it. […]
Done
https://review.coreboot.org/c/coreboot/+/42062/4/src/soc/amd/common/block/al...
File src/soc/amd/common/block/alink/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/4/src/soc/amd/common/block/al...
PS4, Line 2: $(eval $(call verstage-x86,$(CONFIG_SOC_AMD_COMMON_BLOCK_ALINK),alink.c))
Didn't get updated with the latest version.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42062
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I797b67394825172bd44ad1ee693a0c509289486b
Gerrit-Change-Number: 42062
Gerrit-PatchSet: 11
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 21:24:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment