Sam Lewis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44377 )
Change subject: arch/arm: Enable FIT payloads ......................................................................
Patch Set 6:
(2 comments)
Looks like this largely duplicates https://review.coreboot.org/c/coreboot/+/35410 but I'm not sure if that's still active, so I'll keep this open.
https://review.coreboot.org/c/coreboot/+/44377/4/src/arch/arm/fit_payload.c File src/arch/arm/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/44377/4/src/arch/arm/fit_payload.c@... PS4, Line 17: * effectively unbound.
Unlike arm64, arm32 kernels are usually built with a built-in decompressor. […]
Thanks for the explanation, that makes sense. I thought that this bit of "over reserving" was for a slightly different purpose: as kernel->size is the compressed size of the kernel, I thought that kernel->size was inflated so that the fdt and ramdisk wouldn't be overwritten by the kernel decompressor.
I've removed this now and changed the fdt/ramdisk placing logic to make sure they won't get overwritten by the decompressor.
https://review.coreboot.org/c/coreboot/+/44377/4/src/arch/arm/fit_payload.c@... PS4, Line 72: kernel->offset = 0;
Documentation/arm/booting. […]
Good idea, done.