Attention is currently required from: Angel Pons, Deepti Deshatty, Karthik Ramasubramanian, Paul Menzel.
Shelley Chen has posted comments on this change by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/83087?usp=email )
Change subject: mb/google/brox: Add support for batteryless booting
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83087/comment/e1b5a73f_0ee0200c?usp... :
PS4, Line 102: 54 | 56
Are these correct? They come out to be 94 and 96 for 86% efficiency of 110 W.
Yes, when the adapter is very high we don't need to set the PsysPL2 and PL4 values as high as the power consumption of the processor will never get that high. It leaves more power for the rest of the system.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83087?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie36f16b2c938dce29cd2130a86fc8c08f5ba0902
Gerrit-Change-Number: 83087
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 24 Jun 2024 15:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com