21 May
2019
21 May
'19
9:48 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32771 )
Change subject: post_code: add post code for critical CBFS failures ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32771/3/src/soc/intel/quark/romstage/fsp2_0.... File src/soc/intel/quark/romstage/fsp2_0.c:
https://review.coreboot.org/#/c/32771/3/src/soc/intel/quark/romstage/fsp2_0.... PS3, Line 120: die_with_post_code(POST_INVALID_CBFS,
Ack. […]
The commit message doesn't state that you only touch one platform, so I assume you want to update all.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32771
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1c8b92889040f9acd6250f847db02626809a987
Gerrit-Change-Number: 32771
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Short keithshort@chromium.org
Gerrit-Reviewer: Keith Short keithshort@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jett Rink jettrink@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 May 2019 16:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Comment-In-Reply-To: Jett Rink jettrink@chromium.org
Comment-In-Reply-To: Keith Short keithshort@chromium.org
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment