Attention is currently required from: Christian Walter, Angel Pons, Maximilian Brune, Lean Sheng Tan.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 )
Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/atlas/cfr.c:
https://review.coreboot.org/c/coreboot/+/74122/comment/d1c0f2a7_1068b5c2
PS1, Line 14: struct sm_enum_value pwr_after_g3_values[] = {
: { "Power on (S0)", 0 },
: { "Power off (S5)", 1 },
: SM_ENUM_VALUE_END,
: };
These enum values aren't correct, see src/soc/intel/common/block/include/intelblocks/pmclib.h:
```
enum {
MAINBOARD_POWER_STATE_OFF,
MAINBOARD_POWER_STATE_ON,
MAINBOARD_POWER_STATE_PREVIOUS,
};
```
Where we have enums/defines, let's reuse them here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74122
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47585a9a6f94ab5005f2ab63a0df267c0caef231
Gerrit-Change-Number: 74122
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:53:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment