7 Mar
2019
7 Mar
'19
1:39 a.m.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31778 )
Change subject: [WIP] mainboard/google/kahlee: Add additional Micron MT40A512M16TB-062E:J SPD for variants ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31778/2/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc:
https://review.coreboot.org/#/c/31778/2/src/mainboard/google/kahlee/variants... PS2, Line 30: 0b1011
Hi Martin, we'll need your confirmation to define memory ID. thanks.
Hi Kevin, this works for me.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31778
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb4beddf186233fd82ec8f3a01bf14d00b1352ff
Gerrit-Change-Number: 31778
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Mar 2019 16:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-MessageType: comment