Attention is currently required from: Zheng Bao. Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/63015
to review the following change.
Change subject: [TEST]top/Makefile.inc: List the sub directory only for subdirs ......................................................................
[TEST]top/Makefile.inc: List the sub directory only for subdirs
Change-Id: Ic59203d5c52fdce3a6a18ffb54f720f16804a85b Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M Makefile.inc 1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/63015/1
diff --git a/Makefile.inc b/Makefile.inc index 929c236..a44aaef 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -79,12 +79,13 @@
####################################################################### # root source directories of coreboot +subdirs-only=$(patsubst %/,%,$(filter-out $(wildcard $(patsubst %,%/,$(1))),$(sort $(dir $(wildcard $(1)/*/))))) subdirs-y := src/lib src/commonlib/ src/console src/device src/acpi src/superio/common -subdirs-y += src/ec/acpi $(wildcard src/ec/*/*) $(wildcard src/southbridge/*/*) -subdirs-y += $(wildcard src/soc/*) $(wildcard src/soc/*/common) $(filter-out $(wildcard src/soc/*/common),$(wildcard src/soc/*/*)) -subdirs-y += $(wildcard src/northbridge/*/*) -subdirs-y += $(filter-out src/superio/common,$(wildcard src/superio/*)) $(wildcard src/superio/*/*) -subdirs-y += $(wildcard src/drivers/*) $(wildcard src/drivers/*/*) $(wildcard src/drivers/*/*/*) +subdirs-y += src/ec/acpi $(call subdirs-only,src/ec/*) $(call subdirs-only,src/southbridge/*) +subdirs-y += $(call subdirs-only,src/soc) $(wildcard src/soc/*/common) $(filter-out $(wildcard src/soc/*/common),$(call subdirs-only,src/soc/*)) +subdirs-y += $(call subdirs-only,src/northbridge/*) +subdirs-y += $(filter-out src/superio/common,$(call subdirs-only,src/superio)) $(call subdirs-only,src/superio/*) +subdirs-y += $(call subdirs-only,src/drivers) $(call subdirs-only,src/drivers/*) $(call subdirs-only,src/drivers/*/*) subdirs-y += src/cpu src/vendorcode subdirs-y += util/cbfstool util/sconfig util/nvramtool util/pgtblgen util/amdfwtool subdirs-y += util/futility util/marvell util/bincfg util/supermicro util/qemu