Attention is currently required from: Reka Norman, Krishna P Bhat D, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61127 )
Change subject: soc/intel/alderlake: Add eMMC ACPI methods for Alder Lake N
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/alderlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/61127/comment/964e062f_86f00a2f
PS4, Line 42: // Sleep 50 us
:
: PGEN = 0 // Disable PG
nit: use consistent comment style, e,.g. `/* */`
https://review.coreboot.org/c/coreboot/+/61127/comment/bc0ff8c8_a132613b
PS4, Line 55: // Enable PG
nit: use consistent comment style, e,.g. `/* */`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53f04e81584493049d37b46e078d394d3c8a2f09
Gerrit-Change-Number: 61127
Gerrit-PatchSet: 4
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 28 Jan 2022 19:22:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment