Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56580 )
Change subject: commonlib/mem_pool: Allow configuring the alignment
......................................................................
Patch Set 13:
(1 comment)
File src/commonlib/mem_pool.c:
https://review.coreboot.org/c/coreboot/+/56580/comment/07e2a106_46131c26
PS13, Line 11: return NULL;
Only mem_pool_init asserts. Using MEM_POOL_INIT it's still possible (and desirable) to set a 0.
Only when size is 0 too though, right? So then it would drop out in line 18 anyway. (In fact, would probably not hurt to have a _Static_assert(!size == !alignment) in MEM_POOL_INIT().)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d77ffe4411f86c54450305320c9f52ab41a3075
Gerrit-Change-Number: 56580
Gerrit-PatchSet: 13
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 16 Nov 2021 18:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment