Attention is currently required from: Angel Pons, Jérémy Compostella, Nico Huber.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84040?usp=email )
Change subject: ext_stage_cache: Make sure variables are initialized ......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84040/comment/a9fa176a_ca548b15?usp... : PS7, Line 10:
Can the stage cache be disabled?
Done
File src/cpu/x86/smm/tseg_region.c:
https://review.coreboot.org/c/coreboot/+/84040/comment/cd661a51_c1ec2263?usp... : PS7, Line 68: if (smm_subregion(SMM_SUBREGION_CACHE, (uintptr_t *)base, size)) {
You may as well remove the unnecessary brackets while you are at it.
Done
File src/lib/ext_stage_cache.c:
https://review.coreboot.org/c/coreboot/+/84040/comment/bc40082f_0f2c4470?usp... : PS7, Line 18: stage_cache_external_region(&base, &size); : if (base == NULL || size == 0) : return;
Would it make sense to return status from `stage_cache_external_region()`?
if (stage_cache_external_region(&base, &size)) return;
Maybe it makes sense to change the signature but that can be a different change set.