SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )
Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/...
PS2, Line 26: /* A10 : CLKOUT_LPC1 ==> NC */
There is a concern that we'll break some older devices if we update them with this change. […]
There is an issue reset_gpio doesn't works on evt and older devices (operation voltage issue, b:137326841).
Do you want to just keep GPP_A10 to output high for them?
Or we can have another gpio override table for evt and older systems and use it for (board_id <= 3).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35748
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b
Gerrit-Change-Number: 35748
Gerrit-PatchSet: 2
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Fri, 04 Oct 2019 00:40:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment