Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )
Change subject: drivers/vpd: add framework to search VPD in romstage
......................................................................
Patch Set 20:
Patch Set 20:
Hi Philipp/Patrick R.,
I believe I encountered a bug or a setup issue with Gerrit. Following is the sequence:
a. I submitted a new version of patch set.
b. I edited the commit message in Gerrit.
c. I noticed that the build failed: https://qa.coreboot.org/job/coreboot-gerrit/102331/ .
d. I do not know how to trigger a new build, I tried different ways. In the end, I had to introduce a dummy change.
Thanks for looking into this.
What happened is that you updated the patch set (from PS16 to PS17) while PS16 was still being built. The system then killed the build (the log says "Aborted by new patch set.").
That repeated for patch sets 17-19, only patch set 20 got the time to complete the build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34634
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebdba59419a555147fc40391cf17cc6879d9e1b2
Gerrit-Change-Number: 34634
Gerrit-PatchSet: 20
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: Łukasz Siudut
Gerrit-Comment-Date: Thu, 29 Aug 2019 12:35:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment