Attention is currently required from: Paul Menzel.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: soc/intel/: Implement an API to get ISH version ......................................................................
Patch Set 6:
(2 comments)
This change is ready for review.
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/74209/comment/7b222aa0_2d81b82f PS5, Line 544: ROMSTAGE
I think it’s spelled romstage.
Ack
https://review.coreboot.org/c/coreboot/+/74209/comment/a150cca7_b6329623 PS5, Line 547: if the latest ISH version is not updated in the CBMEM table
Sorry I do not understand, what is supposed to be updated.
The API does not update anything, but it provides the user with the current ISH version. It is possible that the stored ISH version is outdated, in which case the API will return false to indicate failure.