Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34369 )
Change subject: soc/amd/common: Avoid stage_cache if !HAVE_ACPI_RESUME
......................................................................
Patch Set 3:
Those are not stage cache function calls you touch here, and they are not strictly S3 related, despite the names.
Kyosti, was it the commit message you don't like? Or is there a problem with the nature of the changes WRT HAVE_ACPI_RESUME? I don't follow your concern about not strictly S3 related, with the exception of InitRtb as I'd mentioned.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34369
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620429d05f924b457d7d1b34fc242a621f273191
Gerrit-Change-Number: 34369
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jul 2019 20:46:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment