Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41086 )
Change subject: SMM: Validate more user-provided pointers
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41086/9/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41086/9/src/southbridge/intel/bd82x...
PS9, Line 114: looks
Always a NOOP? All the checks below only do things if the xhci_bar is even which it cannot be.
Yes, that's fixed in CB:41852 as unrelated to pointer validation
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a347ccdd20816924bf1bceb3b24bf7b22309312
Gerrit-Change-Number: 41086
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jun 2020 18:21:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment