17 Oct
2019
17 Oct
'19
7:29 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35555 )
Change subject: soc/mediatek/mt8183: Run calibration with multiple frequencies for DVFS switch ......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35555/22/src/soc/mediatek/mt8183/em... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35555/22/src/soc/mediatek/mt8183/em... PS22, Line 394: {0x0800, 0x08DC}, @hungte Do you think we should change these magic numbers to something like offsetof(struct dramc_ao_regs, field)?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35555
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97c8e513dc3815a2d62b2904a246a1d8567704a4
Gerrit-Change-Number: 35555
Gerrit-PatchSet: 22
Gerrit-Owner: huayang duan huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: huayang duan huayangduan@gmail.com
Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Oct 2019 07:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment