Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42348 )
Change subject: Revert "arch|cpu/x86: Add Kconfig option for x86 reset vector" ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
I haven't looked at the entire patch stack, but can't we put this section aligned to 16 bytes as the last thing. Then we can relocate adding to cbfs? It should all just work from there w/o manually specifying the location in the linker script.
I have somewhat major rework in followups to get top-aligned bootblock for more efficient FLASH usage. Might be good to just separate PCO from the legacy layout completely.
There is CB:40876 as I though the separation of the linker scripts was unnecessary.
OK. I need to go through your stack still, but I'm sure we can align things. I would expect PCO to link in the same way, but we may need to split to make things easier in the interim.
Any updates? Increased bootblock size with C_ENVIRONMENT_BOOTBLOCK was regression for some, top-aligned bootblock has now been blocked for 6 months, waiting on amd/picasso bootblock linking to get sorted out.
Done here: https://review.coreboot.org/c/coreboot/+/43281. But I think there might be some more changes required as your current stack is pushed forward. I still have to look at the entire series here.