Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61451 )
Change subject: soc/intel/cannonlake: Use SBI msg to disable HECI1
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
this appears to cause a hang during finalization on google/hatch (akemi variant); reverting it allows normal booting
Interesting, On CML platform, we had validated both more actually.
Can you please select SOC_INTEL_COMMON_BLOCK_HECI1_DISABLE_USING_PMC_IPC instead HECI_SMM and see if any luck from SoC Kconfig.
using SOC_INTEL_COMMON_BLOCK_HECI1_DISABLE_USING_PMC_IPC instead of HECI_DISABLE_USING_SMM fixes booting on hatch, but HECI1 is not disabled per lspci
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61451
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6882b619506d1bf4131f68c2c9a32ef4f7d6f6d7
Gerrit-Change-Number: 61451
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Thu, 10 Feb 2022 20:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment