Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83381?usp=email )
Change subject: Documentation/Makefile: Fix test target ......................................................................
Documentation/Makefile: Fix test target
The test target called make with the `-K` flag, which is not valid. Change it to `-k` (keep going if some targets fail) which is what was probably intended.
It also tried to build the `doctest` target from Makefile.sphinx, which results in an error. Further investigation reveals that this is because the sphinx doctest extension was not enabled in conf.py. However, from the documentation of doctest [1], it seems like it is intended to ensure that documentation containing Python snippets along with the expected output of the snippet remain in sync, which is something that we probably don't need. So, remove the call to it.
[1] https://www.sphinx-doc.org/en/master/usage/extensions/doctest.html"
Change-Id: Id514950b4486ed8644d078af222c96ed711fc8f9 Signed-off-by: Nicholas Chin nic.c3.14@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83381 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Elyes Haouas ehaouas@noos.fr --- M Documentation/Makefile 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Nico Huber: Looks good to me, approved Elyes Haouas: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/Documentation/Makefile b/Documentation/Makefile index ec1e1a4..6d2a641 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -31,8 +31,7 @@
test: @echo "Test for logging purposes - Failing tests will not fail the build" - -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -K -f Makefile.sphinx html - -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -K -f Makefile.sphinx doctest + -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -k -f Makefile.sphinx html
help: @echo "all - Builds all documentation targets"