Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41420 )
Change subject: lib: Add strtok() and strtok_r()
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41420/9/src/lib/string.c
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/41420/9/src/lib/string.c@174
PS9, Line 174: if (start[0] == '\0')
With Debian Sid/unstable and clang-tools-9 1:9.0. […]
Seems like a false positive to me. It's not legal to call strtok() with NULL, that's not a bug in our implementation, just how the API is defined. clang probably gets confused because either str or *ptr can be NULL in certain cases, but it doesn't know that it's not legal for both of them to be NULL in the same call.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic855b31669be1c274cbf247c53ffa6f74ec5bf35
Gerrit-Change-Number: 41420
Gerrit-PatchSet: 9
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 25 Jun 2020 20:18:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment