Attention is currently required from: Sean Rhodes, Andy Pont.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62604 )
Change subject: ec/starlabs: Store the correct value for TPLE when suspending
......................................................................
Patch Set 7:
(1 comment)
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/62604/comment/a8133094_c8c92640
PS7, Line 8: ToInteger
Yup, it's possible for it to be 0xbb (we don't want to handle it if it is though)
Hmmm, I don't follow. https://imgur.com/7vs9wC6.png
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I921be8aea55b95f1ba233d2640d9bae80f8c3703
Gerrit-Change-Number: 62604
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Comment-Date: Wed, 09 Mar 2022 14:51:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment