Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 51:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35864/51/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35864/51/Documentation/mainboard/le... PS51, Line 8: # Flashing instructions This is a L1 header. Please change that, it does not work well with sphinx.
https://review.coreboot.org/c/coreboot/+/35864/51/src/mainboard/lenovo/t60/M... File src/mainboard/lenovo/t60/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35864/51/src/mainboard/lenovo/t60/M... PS51, Line 5: ## Copyright (C) 2019 Maciej Matuszczyk Nothing is changed in this file
https://review.coreboot.org/c/coreboot/+/35864/51/src/mainboard/lenovo/t60/g... File src/mainboard/lenovo/t60/gpio.c:
https://review.coreboot.org/c/coreboot/+/35864/51/src/mainboard/lenovo/t60/g... PS51, Line 5: * Copyright (C) 2019 Maciej Matuszczyk We are migrating that to authors. No need to add it here afaik.