Attention is currently required from: Lance Zhao, Hannah Williams, Cliff Huang, Subrata Banik, Kapil Porwal, Paul Menzel, Tim Wawrzynczak, Angel Pons, Nick Vaccaro.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73113 )
Change subject: acpigen: Add print-like function for debug string
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/73113/comment/b830d7a6_9b74226c
PS10, Line 502: void acpigen_write_debug_sprintf(const char *fmt, ...) __attribute__((format(printf, 1, 2)));
Prefer __printf(1, 2) over __attribute__((format(printf, 1, 2))) […]
For timing reason constraints, I will fixed that personally once this patch is merged.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba
Gerrit-Change-Number: 73113
Gerrit-PatchSet: 10
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 10 May 2023 17:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Gerrit-MessageType: comment