Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35634 )
Change subject: vboot: create board-specific test-only GBB HWID if not set ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... File src/security/vboot/gen_hwid.sh:
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 1: #!/bin/sh Shouldn't this go in $(top)/util/? I think host code (even scripts) is generally not allowed under $(top)/src/. (Then again, this is short enough that you could just put it inline into the Makefile...)
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 28: if [ -n "${override}" ]; then nit: this part would also be easy to do within make (with $(if ...)).
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 38: crc="$(python -c "import zlib, sys; sys.stdout.write(\ IIRC the coreboot build system is not supposed to depend on Python, unless something changed there that I'm not aware of. Individual boards/SoCs may have Python packaging tools if they need them, but not a general, platform-independent feature.
Maybe it's possible to write this in awk (which I think is generally considered "available everywhere")? (Maybe the second version in https://stackoverflow.com/questions/4994537/calculating-crc-in-awk , but haven't tried it.)