Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34753 )
Change subject: soc/intel/{cnl, icl}: Set CONFIG_CPU_ADDR_BITS to 39
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34753/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34753/3//COMMIT_MSG@14
PS3, Line 14: Also this change helps to generate correct MTRR mask value while
: using set_var_mtrr
Is the problem fixed by using cpu_phys_address_size() in earlymtrr. […]
should be yes, i was actually using set_var_mtrr as many places in common code block we are using set_var_mtrr for enabling temp MTRR.
As per my understating all set_var_mtrr() usage might need this change to make it proper or else lets replace CONFIG_CPU_ADDR_BITS in set_var_mtrr() with cpu_phys_address_size() to fix for all.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34753
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3185dd8d4af73ec0605e19e9aa4223f2c2ad462
Gerrit-Change-Number: 34753
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 07 Aug 2019 02:53:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment