Attention is currently required from: Furquan Shaikh, Paul Menzel, Angel Pons, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56650 )
Change subject: soc/intel/common: Don't suppress SPD Module Type value
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/56650/comment/f4b9055e_b350bc92
PS3, Line 18: /* Translate to DDR2 module type field that SMBIOS code expects. */
Yes i don't know that answer either and IMHO we should let platform choose if they want to go thro […]
i believe, we can combine DDRx and LPx to reduce the if/else as most of the types are same in those spec. isn't it ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56650
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3f38c24efa6a8685639bb607926e2fd9c702ff6
Gerrit-Change-Number: 56650
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 28 Jul 2021 21:02:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment