Attention is currently required from: Eric Lai, Fred Reitberger, Jon Murphy, Martin L Roth, Martin Roth, Matt DeVillier, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75659?usp=email )
Change subject: drivers/usb/pci_xhci: Add two xhci DID for phoenix
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
hm, we should attach the driver to the device in the devicetree to significantly lower the chance of missing this again in the next soc generation.
adding "ops xhci_pci_ops" right below "device pci 0.3 alias xhci_0 off" and the other 3 xhci controllers in the chipset devicetree should do the same and would also allow us to get rid of the pci id table. devices 0x15C0 and 0x15C1 are probably missing from this patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75659?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib59874948725966b04b54def3f6de463afeda709
Gerrit-Change-Number: 75659
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 07 Jun 2023 00:58:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment