[coreboot-gerrit] [M] Change in coreboot[master]: acpi: Add functions to declare ARM GIC V3 hardware

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Held, Julius Werner, Lance Zhao, Tim Wawrzynczak.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76132?usp=email )

Change subject: acpi: Add functions to declare ARM GIC V3 hardware
......................................................................

Patch Set 6:

(3 comments)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/76132/comment/58f18eb1_9ab21633 :
PS6, Line 147: 	if (CONFIG(ACPI_COMMON_MADT_GICC_V3)) {
Do we want the calls here or introduce acpi_arch_fill_madt() for aarch64?

File src/acpi/acpi_gic.c:

https://review.coreboot.org/c/coreboot/+/76132/comment/b0fa0c30_bbc50084 :
PS3, Line 22: 	/* For platforms implementing ARMv8 the format must be:
Maybe this comment is a bit confusing, should this refer to GICC v3 ?

File src/arch/arm64/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/76132/comment/d5b89e6e_08dc25a9 :
PS5, Line 122: ramstage-$(CONFIG_ACPI_COMMON_MADT_GICC_V3) += ../../acpi/acpi_gic.c
> > Why put that here and not in acpi/Makefile.inc? […]

FelixH and I thought that arch/x86 should be revisited for this, CB:76008.