Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69339 )
Change subject: Revert "mb/aopen/dxplplusu: Remove board"
......................................................................
Patch Set 5:
(2 comments)
File src/cpu/intel/model_f2x/model_f2x_init.c:
https://review.coreboot.org/c/coreboot/+/69339/comment/6dffed0d_dcab574e
PS2, Line 17: if (!intel_ht_sibling()) {
: /* MTRRs are shared between threads */
: x86_setup_mtrrs();
: x86_mtrr_check();
:
: /* Update the microcode */
: intel_update_microcode_from_cbfs();
: }
:
: /* Start up my CPU siblings */
: intel_sibling_init(cpu);
Done but not tested
Ack
File src/mainboard/aopen/dxplplusu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69339/comment/f0f2491a_b32464b0
PS2, Line 6: chip cpu/intel/socket_mPGA604
: device lapic 0 on end
: device lapic 6 on end
: end
The parallel mp init does not need this anymore and it might even confuse it. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69339
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1cd02278240d1b5d006fb2a7730d3d86390f85b
Gerrit-Change-Number: 69339
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 09 Nov 2022 04:57:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment