Attention is currently required from: Felix Singer, Jeremy Soller, Nick Vaccaro, Jonathon Hall, Michael Niewöhner, Piotr Król, Tim Crawford, Nico Huber, Sean Rhodes, Tarun Tuli, Martin L Roth, Michał Żygowski, Subrata Banik, Kapil Porwal.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69206 )
Change subject: soc/intel/common: add units to soc_power_limits_config elements
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/starlabs/lite/devtree.c:
https://review.coreboot.org/c/coreboot/+/69206/comment/7f7005e7_f0bd927f
PS1, Line 43: cfg->tcc_offset = 5;
nit: Alignment
Hi Sean,
Do you need my help to correct the alignment?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f954742c525e220f61d0fa5c74f4c75fd9648ef
Gerrit-Change-Number: 69206
Gerrit-PatchSet: 1
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 03:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Gerrit-MessageType: comment