Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44076 )
Change subject: soc/intel/common/block/cpu: Refactor init_cpus function
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44076/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/c/coreboot/+/44076/5/src/soc/intel/common/block/...
PS5, Line 142: intel_microcode_load_unlocked
I believe we have checks inside "src/cpu/intel/microcode/microcode. […]
Then, we might as well skip it when using FSP MP init, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc03090360f34df074b33ba0fced2d192edf068a
Gerrit-Change-Number: 44076
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 31 Jul 2020 14:32:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment