Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42453 )
Change subject: soc/intel/jasperlake: Add the SkipCpuReplacementCheck configuration ......................................................................
Patch Set 4: Code-Review+2
(5 comments)
https://review.coreboot.org/c/coreboot/+/42453/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42453/1//COMMIT_MSG@9 PS1, Line 9: enable
enables
Done
https://review.coreboot.org/c/coreboot/+/42453/1//COMMIT_MSG@9 PS1, Line 9: fspm
FSP-M
Done
https://review.coreboot.org/c/coreboot/+/42453/1//COMMIT_MSG@9 PS1, Line 9: upd
UPD
Done
https://review.coreboot.org/c/coreboot/+/42453/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42453/4//COMMIT_MSG@16 PS4, Line 16: Change-Id: I63fcdab3686322406cf7c24fc26cbb535cc58c8d Add:
Cq-Depend: chrome-internal:3142530
https://review.coreboot.org/c/coreboot/+/42453/1/src/soc/intel/jasperlake/ro... File src/soc/intel/jasperlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42453/1/src/soc/intel/jasperlake/ro... PS1, Line 117: /* Setting this option to skip CPU replacement check */
Why are we skipping the CPU replacement check? I would prefer having a comment that explains this
Done