[coreboot-gerrit] [S] Change in coreboot[master]: fmap/region: Call the munmap of access_dev in xlate_windows

[Julius Werner (Code Review)]

Attention is currently required from: Bao Zheng, Jason Glenesk, Aaron Durbin, Furquan Shaikh, Marshall Dawson, Zheng Bao, Martin Roth, Fred Reitberger, Felix Held.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74259 )

Change subject: fmap/region: Call the munmap of access_dev in xlate_windows
......................................................................

Patch Set 1:

(1 comment)

File src/commonlib/region.c:

https://review.coreboot.org/c/coreboot/+/74259/comment/62ed4fba_7c7984e1 
PS1, Line 381: 	xlwindow = &xldev->window_arr[0];
I don't think this is safe. You're just assuming here that the mapping you're trying to unmap comes from the first window, but you do not know that. If you call unmap() on an rdev that didn't actually originally map this pointer to begin with, that could cause bad consequences (I mean maybe it doesn't with the current rdev implementations that use this, but in theory it could).