Attention is currently required from: David Wu, YH Lin, Ofer Fried, Ricardo Ribalda, Tim Wawrzynczak, Andy Yeh, Jim Lai.
Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68890 )
Change subject: mb/google/brya/var/kano: Add mipi hi556 camera support
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/variants/kano/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68890/comment/a2f758bd_18cfdd3a
PS2, Line 337: register "link_freq[0]" = "437000000"
nit: 437 * MHz
https://review.coreboot.org/c/coreboot/+/68890/comment/715151b5_2d20c1e2
PS2, Line 346: register "gpio_panel.gpio[1].gpio_num" = "GPP_F20" #reset
gpio 0 and 1 are swapped compared to Ov 2740, is this on purpose?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34dbf67634ecd364c40c6e934217af3d8efe1689
Gerrit-Change-Number: 68890
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Jim Lai
jim.lai@intel.com
Gerrit-Reviewer: Ofer Fried
oferfried@google.com
Gerrit-Reviewer: Ricardo Ribalda
ribalda@google.com
Gerrit-Reviewer: Ricky Liang
jcliang@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Grace Kao
grace.kao@intel.com
Gerrit-CC: Ricardo Ribalda
ribalda@chromium.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Ofer Fried
oferfried@google.com
Gerrit-Attention: Ricardo Ribalda
ribalda@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Andy Yeh
andy.yeh@intel.com
Gerrit-Attention: Jim Lai
jim.lai@intel.com
Gerrit-Comment-Date: Thu, 27 Oct 2022 06:50:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment