Attention is currently required from: Alexander Couzens, Arthur Heymans, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, Nicholas Sudsgaard, Paul Menzel.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M700/M900 Tiny board (Skylake/Kaby Lake) ......................................................................
Patch Set 6:
(8 comments)
File src/mainboard/lenovo/m900_tiny/Kconfig:
PS5:
Add SPDX license here.
Done
File src/mainboard/lenovo/m900_tiny/Kconfig.name:
PS5:
Add SPDX license here.
Done
File src/mainboard/lenovo/m900_tiny/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/80610/comment/f44591c4_d2f44e5d : PS5, Line 1: GPL-2.0-or-later
Empty files should use the CC-PDDC license (refer to CB:66497)
Right, added
File src/mainboard/lenovo/m900_tiny/cmos.default:
PS5:
Add SPDX license here (refer to CB:80597)
Done
File src/mainboard/lenovo/m900_tiny/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80610/comment/92345b49_c85cafb7 : PS5, Line 133: register "usb2_ports[0]" = "USB2_PORT_MID(OC0)" # Front Port 1
I would suggest this format for bulk definitions. […]
Done
https://review.coreboot.org/c/coreboot/+/80610/comment/648eef44_31ab3006 : PS5, Line 142: register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC0)" # Front Port 1
Here too.
Done
https://review.coreboot.org/c/coreboot/+/80610/comment/95154663_7348704c : PS5, Line 154: register "SataPortsEnable" = "{ \
'' is not necessary.
Done
https://review.coreboot.org/c/coreboot/+/80610/comment/c07bc1b2_43f5fa9d : PS5, Line 162: register "SataPortsHotPlug" = "{ \
Here too.
Done