Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34342 )
Change subject: DO NOT SUBMIT: It's just to study how to create a new variant. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34342/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/34342/2/src/mainboard/google/hatch/... PS2, Line 27: /* F11 : EMMC_CMD ==> EMMC_CMD */ : PAD_CFG_NF(GPP_F11, UP_20K, DEEP, NF1), : /* F12 : EMMC_DATA0 ==> EMMC_DAT0 */ : PAD_CFG_NF(GPP_F12, UP_20K, DEEP, NF1), : /* F13 : EMMC_DATA1 ==> EMMC_DAT1 */ : PAD_CFG_NF(GPP_F13, UP_20K, DEEP, NF1), : /* F14 : EMMC_DATA2 ==> EMMC_DAT2 */ : PAD_CFG_NF(GPP_F14, UP_20K, DEEP, NF1), : /* F15 : EMMC_DATA3 ==> EMMC_DAT3 */ : PAD_CFG_NF(GPP_F15, UP_20K, DEEP, NF1), : /* F16 : EMMC_DATA4 ==> EMMC_DAT4 */ : PAD_CFG_NF(GPP_F16, UP_20K, DEEP, NF1), : /* F17 : EMMC_DATA5 ==> EMMC_DAT5 */ : PAD_CFG_NF(GPP_F17, UP_20K, DEEP, NF1), : /* F18 : EMMC_DATA6 ==> EMMC_DAT6 */ : PAD_CFG_NF(GPP_F18, UP_20K, DEEP, NF1), : /* F19 : EMMC_DATA7 ==> EMMC_DAT7 */ : PAD_CFG_NF(GPP_F19, UP_20K, DEEP, NF1), : /* F20 : EMMC_RCLK ==> EMMC_RCLK */ : PAD_CFG_NF(GPP_F20, DN_20K, DEEP, NF1), : /* F21 : EMMC_CLK ==> EMMC_CLK */ : PAD_CFG_NF(GPP_F21, DN_20K, DEEP, NF1), Need configure PAD and make sure meet Intel PGD requirement.