Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43644 )
Change subject: mb/system76/lemp9: gpio: configure unused pads ......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43644/18/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/gpio.h:
PS18:
Please add the new pads in a follow-up commit.
I have not added any new pads; all pads where there already
PS18:
Configure the 20k pull-ups for the NC pads in a follow-up commit. […]
This patch does a single thing: configure the NC pads according to schematics. Yes, that involves dropping the macro but there is no gain in doing that in a single commit. Further, reproducibility is not wanted because some NC pads are plain wrong -> we get nothing from reproducibility here.