Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36290 )
Change subject: arch/x86/cbmem.c: Drop API to save cbmem_top across stages
......................................................................
Patch Set 2:
Patch Set 2: Code-Review-2
(1 comment)
I'm pretty confident about the -2 here.
And seemingly no easy way to fix it either...
AGESA needs nvram storage to get back Sub4GCacheTop amongst other things and you also need to also have nvram storage for coreboot to do do the same?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I733a4810b6507752b68f8508a486fbd577289658
Gerrit-Change-Number: 36290
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Oct 2019 23:58:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment