Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45742 )
Change subject: mainboard/volteer: enable early tcss chrome ec related code in mainboard
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45742/5/src/mainboard/google/voltee...
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45742/5/src/mainboard/google/voltee...
PS5, Line 93: //Hard coding these values until the dynamic setting is upstreamed
: if (i == 0) {
: mux_data.usb2_port = 9;
: mux_data.usb3_port = 1;
: } else if (i == 1) {
: mux_data.usb2_port = 4;
: mux_data.usb3_port = 2;
: }
:
Here's what I've got right now: […]
Ahh I didn't try using the EC devices I added new aliases under SOC to test and thats where I was getting the invalid values for the port numbers back. Will implement using the EC devices and see what the difference is in the return values
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c151caa84c1970c77386d9eca156fd3c7f2a12
Gerrit-Change-Number: 45742
Gerrit-PatchSet: 5
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 10 Nov 2020 22:53:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment