Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42678 )
Change subject: mb/google/volteer/variants/volteer : Tune I2C0,I2C1,I2C2,I2C3,I2C5 params for Trackpad,Audio,Touchscreen, WLAN,SAR0,Camera,SAR1 Camera
......................................................................
Patch Set 20:
i would still suggest splitting this patch up into a separate patch for each peripheral or I2C bus.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20cb10455932822744b09aa347e271a0ec064eb6
Gerrit-Change-Number: 42678
Gerrit-PatchSet: 20
Gerrit-Owner: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Johnny Li
johnny_li@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 07:51:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment