Name of user not set #1002517 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34835 )
Change subject: drivers/ipmi: make IPMI KCS status and command register offset configurable ......................................................................
Patch Set 2:
(2 comments)
Patch Set 2: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig File src/drivers/ipmi/Kconfig:
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@5 PS2, Line 5: choice
why is it user configurable? […]
Yes it is board/BMC specific, but coreboot needs to modify the offset to match BMC's configuration, for Mono Lake the offset is 4 (32-bit boundaries).
https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@15 PS2, Line 15: bool "IPMI KCS register address offset 2 (WORD)"
that's not part of the spec. […]
Yes you are right, I will remove this part in my next patch set. Because I don't have device that can verify 16-byte boundaries so in this commit I will only add options for byte and 32-bit boundaries.