Attention is currently required from: Sean Rhodes, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59979 )
Change subject: mb/starlabs/labtop: Store serial number in CMOS
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
I'm not sure if storing serial numbers in CMOS is a good idea, but I can't think of an alternative a […]
I don't think this is a good idea either. How about VPD?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70c35c8f99f7e3ac8e45e742156dca741a6c6933
Gerrit-Change-Number: 59979
Gerrit-PatchSet: 11
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 20 Dec 2021 00:49:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment